Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: color palette changes #30385

Merged
merged 6 commits into from
Sep 18, 2023
Merged

chore: color palette changes #30385

merged 6 commits into from
Sep 18, 2023

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Sep 13, 2023

Proposed changes (including videos or screenshots)

  • update font-danger color DSAR-265
  • add default palette as fallback
  • add .rcx-tile selector to main palette to fix menu colors on sidebar: DSAR-264

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2023

⚠️ No Changeset found

Latest commit: dc8d7bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #30385 (dc8d7bd) into develop (b1c2a4c) will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30385      +/-   ##
===========================================
- Coverage    50.18%   49.96%   -0.23%     
===========================================
  Files          781      776       -5     
  Lines        14507    14488      -19     
  Branches      2621     2616       -5     
===========================================
- Hits          7281     7239      -42     
- Misses        6829     6839      +10     
- Partials       397      410      +13     
Flag Coverage Δ
e2e 48.34% <ø> (-0.26%) ⬇️
unit 60.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review September 15, 2023 18:16
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 18, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 18, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 18, 2023
@kodiakhq kodiakhq bot merged commit 5ce4c41 into develop Sep 18, 2023
42 checks passed
@kodiakhq kodiakhq bot deleted the chore/palette-changes branch September 18, 2023 15:26
gabriellsh added a commit that referenced this pull request Sep 19, 2023
…ove/iframeLogin

* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits)
  fix: Disables `GenericMenu` without any sections or items (#30319)
  i18n: Language update from LingoHub 🤖 on 2023-09-18Z (#30426)
  chore:  remove connectToCloud option (#30430)
  chore: remove Troubleshoot options (#30429)
  chore: bump fuselage packages (#30424)
  chore: Webhooks page refactor (#30274)
  chore: color palette changes (#30385)
  fix: increase cron job check delay to 1 min (#30402)
  fix: Presence broadcast isn't enabled after license validation (#30282)
  test: create non private team and readonly team (#30371)
  Bump version to 6.5.0-develop
  refactor: Implement functional code for the 'useFilteredApps' hook (#30279)
  Release 6.4.0-rc.1
  Release 6.3.6
  regression: Login page callout messages (#30399)
  test: tests for muting and unmuting (#30286)
  regression: Fix rooms table not showing teams (#30361)
  regression: Move queue-timeout setting to CE and remove dependency on waiting queue (#30386)
  fix: engagement dashboard not working (#30277)
  Bump 6.3.6
  ...
MartinSchoeler pushed a commit that referenced this pull request Sep 26, 2023
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants